Skip to content

feat(secretmanager): Added samples for tags field #2140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

durgesh-ninave-crest
Copy link
Contributor

@durgesh-ninave-crest durgesh-ninave-crest commented Jun 25, 2025

Description

Created samples for Global and Regional Secret Manager API

Samples (Global, Regional)

  1. Create Secret With Tags
  2. Bind Tags to Secret

Ref: https://cloud.google.com/secret-manager/docs/create-and-manage-tags

Checklist

  • I have followed guidelines from the CONTRIBUTING.MD
  • Appropriate changes to README are included in PR
  • Test passed: ../testing/vendor/bin/phpunit test/ -v
  • Lint passed: php-cs-fixer fix . --config .php-cs-fixer.dist.php
  • These samples need a new API enabled in testing projects to pass (let us know which ones) (To use the tags field, add the SM_TAGS_TESTER label to the Secret Manager service in the project using: tm labels add secretmanager.googleapis.com SM_TAGS_TESTER <project_name> )

Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples. labels Jun 25, 2025
@durgesh-ninave-crest durgesh-ninave-crest marked this pull request as ready for review June 26, 2025 09:24
@durgesh-ninave-crest durgesh-ninave-crest requested review from a team as code owners June 26, 2025 09:24
Copy link

snippet-bot bot commented Jun 26, 2025

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link

@YashSaraf11 YashSaraf11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@YashSaraf11 YashSaraf11 merged commit cf3c3c5 into GoogleCloudPlatform:main Jul 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants