feat(compute): support self_link input for google_compute_network data source#17393
Open
raman1236 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Open
feat(compute): support self_link input for google_compute_network data source#17393raman1236 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
raman1236 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
…a source The `google_compute_network` data source previously required `name` to look up a network. This adds support for looking up a network by `self_link`, which is useful when you have a self_link from another resource and want to look up network details without parsing the name. Changes: - `name` is now Optional+Computed (was Required) - `self_link` is now Optional+Computed (was Computed only) - `project` is now Computed in addition to Optional - Read function parses project and name from self_link when provided - Validates that either `name` or `self_link` is provided Includes unit tests for self_link parsing. Fixes hashicorp/terraform-provider-google#7863
modular-magician
added
the
awaiting-approval
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
google_compute_networkdata source previously requirednameto look up a network. This adds support for looking up a network byself_link, which is useful when you have a self_link from another resource and want to look up network details without parsing out the name yourself.Changes
nameis nowOptional+Computed(wasRequired)self_linkis nowOptional+Computed(wasComputedonly)projectis nowComputedin addition toOptionalself_linkwhen providednameorself_linkis providedNew or Affected Resource(s)
google_compute_network(data source)Bug
Fixes hashicorp/terraform-provider-google#7863
Tests
Includes unit tests for self_link parsing (full URL, partial path, beta API).
Files changed
mmv1/third_party/terraform/services/compute/data_source_google_compute_network.gommv1/third_party/terraform/services/compute/data_source_google_compute_network_internal_test.go(new)