fix(compute): prevent panic in google_compute_service_attachment target_service expansion#17390
Open
raman1236 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Open
Conversation
…et_service expansion The custom expand function for `target_service` previously split the input by "/" and required at least 4 segments, returning an error and panicking for short resource names. Users referencing resources by name (e.g. `google_network_services_gateway.*.name`) hit confusing errors. Since the DiffSuppressFunc (`CompareSelfLinkOrResourceName`) already handles comparing self_links with names, and the API validates the value, we can simply pass the value through. Fixes hashicorp/terraform-provider-google#22206
modular-magician
added
the
awaiting-approval
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The custom expand function for
target_serviceingoogle_compute_service_attachmentpreviously split the input by "/" and required at least 4 segments, returning an error for short resource names. Users referencing resources by name (e.g.google_network_services_gateway.*.name) hit confusing "invalid value for target_service" errors.Since the DiffSuppressFunc (
CompareSelfLinkOrResourceName) already handles comparing self_links with names, and the API validates the value, we can simply pass the value through.Bug
Fixes hashicorp/terraform-provider-google#22206
File changed
mmv1/templates/terraform/custom_expand/service_attachment_target_service.go.tmpl