transport: add itemName fallback for transport.ListPages()#17371
transport: add itemName fallback for transport.ListPages()#17371BBBmau wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
transport: add itemName fallback for transport.ListPages()#17371Conversation
|
@modular-magician reassign-reviewer |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 80a5200: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. 🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the build log or the debug logs folder for detailed results. @BBBmau, @SirGitsalot VCR tests complete for 80a5200! |
|
/gcbrun |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 80a5200: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the build log or the debug logs folder for detailed results. @BBBmau, @SirGitsalot VCR tests complete for 80a5200! |
SirGitsalot
left a comment
There was a problem hiding this comment.
Seems like the usual suspect tests that are failing.
Release Note Template for Downstream PRs (will be copied)
I noticed that sweeper_file.go.tmpl includes a fallback for
itemswhen the default list key value is used but returns!okIncluding this fallback makes sense in the case of
ListPagesas we would default to usingcollection_url_keyin generated list resources but due to the generation not including the fallback an explicit change tocollection_url_key -> itemswas often necessarySee Write release notes for guidance.