Skip to content

transport: add itemName fallback for transport.ListPages()#17371

Open
BBBmau wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
BBBmau:add-items-fallback-listPages
Open

transport: add itemName fallback for transport.ListPages()#17371
BBBmau wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
BBBmau:add-items-fallback-listPages

Conversation

@BBBmau
Copy link
Copy Markdown
Collaborator

@BBBmau BBBmau commented Apr 30, 2026

Release Note Template for Downstream PRs (will be copied)

I noticed that sweeper_file.go.tmpl includes a fallback for itemswhen the default list key value is used but returns !ok

Including this fallback makes sense in the case of ListPages as we would default to using collection_url_key in generated list resources but due to the generation not including the fallback an explicit change to collection_url_key -> items was often necessary

See Write release notes for guidance.


@BBBmau
Copy link
Copy Markdown
Collaborator Author

BBBmau commented Apr 30, 2026

@modular-magician reassign-reviewer

@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions Bot requested a review from SirGitsalot April 30, 2026 23:48
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Apr 30, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 80a5200:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 6 insertions(+), 7 deletions(-)
google-beta provider View Diff 1 file changed, 6 insertions(+), 7 deletions(-)
terraform-google-conversion View Diff 1 file changed, 6 insertions(+), 7 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
6385 5717 655 13
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
  • TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccContainerCluster_updateVersion
  • TestAccContainerCluster_withAutopilotResourceManagerTags
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the build log


Step 2: Recording Mode

Test Name Recording Mode Replaying Rerun
TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample 🔴 Failed [Error message] [Debug log] -
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample 🔴 Failed [Error message] [Debug log] -
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample 🔴 Failed [Error message] [Debug log] -
TestAccCloudRunService_cloudRunServiceGpuExample 🔴 Failed [Error message] [Debug log] -
TestAccContainerCluster_updateVersion 🔴 Failed [Error message] [Debug log] -
TestAccContainerCluster_withAutopilotResourceManagerTags 🔴 Failed [Error message] [Debug log] -
TestAccContainerNodePool_withHostMaintenancePolicy 🔴 Failed [Error message] [Debug log] -
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample 🔴 Failed [Error message] [Debug log] -
TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample 🔴 Failed [Error message] [Debug log] -
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample 🔴 Failed [Error message] [Debug log] -
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample 🔴 Failed [Error message] [Debug log] -
TestAccProjectIamMemberRemove_memberInMultipleBindings 🟢 Passed [Debug log] 🔴 Failed [Error message] [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionTagsExample 🔴 Failed [Error message] [Debug log] -

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@BBBmau, @SirGitsalot VCR tests complete for 80a5200!

@zli82016
Copy link
Copy Markdown
Member

zli82016 commented May 1, 2026

/gcbrun

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 1, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 80a5200:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 6 insertions(+), 7 deletions(-)
google-beta provider View Diff 1 file changed, 6 insertions(+), 7 deletions(-)
terraform-google-conversion View Diff 1 file changed, 6 insertions(+), 7 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
6385 5718 655 12
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
  • TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccContainerCluster_updateVersion
  • TestAccContainerCluster_withAutopilotResourceManagerTags
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the build log


Step 2: Recording Mode

Test Name Recording Mode Replaying Rerun
TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample 🔴 Failed [Error message] [Debug log] -
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample 🔴 Failed [Error message] [Debug log] -
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample 🔴 Failed [Error message] [Debug log] -
TestAccCloudRunService_cloudRunServiceGpuExample 🔴 Failed [Error message] [Debug log] -
TestAccContainerCluster_updateVersion 🔴 Failed [Error message] [Debug log] -
TestAccContainerCluster_withAutopilotResourceManagerTags 🔴 Failed [Error message] [Debug log] -
TestAccContainerNodePool_withHostMaintenancePolicy 🔴 Failed [Error message] [Debug log] -
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample 🔴 Failed [Error message] [Debug log] -
TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample 🔴 Failed [Error message] [Debug log] -
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample 🔴 Failed [Error message] [Debug log] -
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample 🔴 Failed [Error message] [Debug log] -
TestAccPubsubSubscription_pubsubSubscriptionTagsExample 🔴 Failed [Error message] [Debug log] -

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@BBBmau, @SirGitsalot VCR tests complete for 80a5200!

Copy link
Copy Markdown
Member

@SirGitsalot SirGitsalot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the usual suspect tests that are failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants