Add styledata proto definition and corresponding type definitions#533
Draft
kyasbal wants to merge 5 commits intoGoogleCloudPlatform:mainfrom
Draft
Add styledata proto definition and corresponding type definitions#533kyasbal wants to merge 5 commits intoGoogleCloudPlatform:mainfrom
kyasbal wants to merge 5 commits intoGoogleCloudPlatform:mainfrom
Conversation
kyasbal
force-pushed
the
epic/proto-add-styledata
branch
from
6dcaa48 to
4e06832
Compare
Contributor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a protobuf definition for StyleData to centralize styling information, moving it out of the Go code. This is a significant and positive refactoring for maintainability. The changes include adding the proto file, buf configuration for code generation, generated Go and TypeScript files, and updating the task registration mechanism to handle the new style data types. My review focuses on the new implementation details. I've found some opportunities to reduce code duplication. Overall, this is a well-structured change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR defines a proto type definition used for conveying style information in the new file format.
The most of changes included in this change is the generated code file from proto and variable definitions matching with the current values defined under pkg/enum.