Skip to content

Adding support for Unity stack traces #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewgrundy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding support for Unity stack traces #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/fluent/plugin/exception_detector.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,17 @@ def self.supported
rule(:dart_stack, /^<asynchronous suspension>$/, :dart_stack)
].freeze

UNITY_RULES = [
rule(:start_state, /^Caught fatal signal.*$/, :unity_stack_begin),
rule(:unity_stack_begin, /^Obtained \d+ stack frames.*$/,
:unity_stack_frames),
rule(:unity_stack_frames, /^#\d.*in _start$/, :start_state),
rule(:unity_stack_frames, /^#\d/, :unity_stack_frames)
].freeze

ALL_RULES = (
JAVA_RULES + PYTHON_RULES + PHP_RULES + GO_RULES + RUBY_RULES + DART_RULES
JAVA_RULES + PYTHON_RULES + PHP_RULES + GO_RULES + RUBY_RULES +
DART_RULES + UNITY_RULES
).freeze

RULES_BY_LANG = {
Expand All @@ -165,6 +174,7 @@ def self.supported
rb: RUBY_RULES,
ruby: RUBY_RULES,
dart: DART_RULES,
unity: UNITY_RULES,
all: ALL_RULES
}.freeze

Expand Down
31 changes: 31 additions & 0 deletions test/plugin/test_exception_detector.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,6 +559,33 @@ class ExceptionDetectorTest < Test::Unit::TestCase
#3 main (file:///path/to/code/dartFile.dart:10:3)
#4 _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:265)
#5 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:151)
END

UNITY_ERR = <<END.freeze
Caught fatal signal - signo:5 code:-6 errno:0 addr:0x1
Obtained 22 stack frames.
#0 0x007f94d638168f in DebugStringToFile(DebugStringToFileData const&)
#1 0x007f94d5c87aee in DiagnosticsUtils_Bindings::ForceCrash(DiagnosticsUtils_Bindings::ForcedCrashCategory, ScriptingExceptionPtr*)
#2 0x007f94d5dde998 in Utils_CUSTOM_ForceCrash(DiagnosticsUtils_Bindings::ForcedCrashCategory)
#3 0x0000004160b80d in (wrapper managed-to-native) UnityEngine.Diagnostics.Utils:ForceCrash (UnityEngine.Diagnostics.ForcedCrashCategory)
#4 0x0000004144fa02 in System.Runtime.CompilerServices.AsyncMethodBuilderCore/MoveNextRunner:InvokeMoveNext (object)
#5 0x00000041292063 in System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
#6 0x000000414f21f9 in System.Threading.Tasks.SynchronizationContextAwaitTaskContinuation/<>c:<.cctor>b__7_0 (object)
#7 0x000000414ece0b in UnityEngine.UnitySynchronizationContext:Exec ()
#8 0x000000414ec723 in UnityEngine.UnitySynchronizationContext:ExecuteTasks ()
#9 0x007f94d3582505 in mono_print_method_from_ip
#10 0x007f94d36f15c3 in mono_perfcounter_foreach
#11 0x007f94d36f2470 in mono_runtime_invoke
#12 0x007f94d5ceb292 in scripting_method_invoke(ScriptingMethodPtr, ScriptingObjectPtr, ScriptingArguments&, ScriptingExceptionPtr*, bool)
#13 0x007f94d5ce92df in ScriptingInvocation::Invoke(ScriptingExceptionPtr*, bool)
#14 0x007f94d4ee5a87 in Scripting::UnityEngine::UnitySynchronizationContextProxy::ExecuteTasks(ScriptingExceptionPtr*)
#15 0x007f94d5aa602f in InitPlayerLoopCallbacks()::UpdateScriptRunDelayedTasksRegistrator::Forward()
#16 0x007f94d5a993ee in ExecutePlayerLoop(NativePlayerLoopSystem*)
#17 0x007f94d5a9945a in ExecutePlayerLoop(NativePlayerLoopSystem*)
#18 0x007f94d5a999d2 in PlayerLoop()
#19 0x007f94d5d57f7e in PlayerMain(int, char**)
#20 0x007f94d46e009b in __libc_start_main
#21 0x00555a30fc8689 in _start
END

ARBITRARY_TEXT = <<END.freeze
Expand Down Expand Up @@ -603,6 +630,10 @@ def check_exception(exception, detects_end)
check_multiline(detector, before_second_exc, after_exc, exception)
end

def test_unity
check_exception(UNITY_ERR, true)
end

def test_java
check_exception(JAVA_EXC, false)
check_exception(COMPLEX_JAVA_EXC, false)
Expand Down