Fix AlloyDB context templates and password generation in deploy_alloydb.sh - #14
Merged
gotochkin merged 3 commits intoAug 11, 2026
Conversation
added 3 commits
August 7, 2026 22:46
- Define real_estate.school_score SQL function in real_estate_data.sql. - Fix malformed parameterized_sql key in sixrecipe_context1_2.json. - Fix spelling typo for appliances in sixrecipe_context4_3.json.
…mplates with real_estate.school_score function
…ontext templates - Remove real_estate.school_score function definition from real_estate_data.sql. - Revert all context JSON templates to use inlined weighted formula (0.8 * school_ranking + 0.2 * proximity_miles).
azielman
changed the title
gotochkin
self-requested a review
August 10, 2026 20:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issues identified in the
alloydb-ai-nlacodelab:deploy_alloydb.sh: Uses alphanumeric character filtering to ensure robust password generation without unsupported characters.sixrecipe_context4_3.json: Replaces the remainingreal_estate.school_scorereference with the direct weighted ranking formula (0.8 * "s"."school_ranking" + 0.2 * "stp"."proximity_miles"), ensuring consistency across all context templates without requiring a custom database function.sixrecipe_context1_2.jsonparameterized structure: Corrects theparameterizedblock so thatparameterized_sqlcontains the actual parameterized SQL query rather than the natural language manifest string, and removes the invalid"sql"key.sixrecipe_context4_3.json: Corrects the spelling of"appliences"to"appliances"across template metadata fields in Template 3.