Parameterise gIB NCCL RDMA plugin installer in gke a4x

[parulbajaj01]

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

• Fork your PR branch from the Toolkit "develop" branch (not main)
• Test all changes with pre-commit in a local branch #
• Confirm that "make tests" passes all tests
• Add or modify unit tests to cover code changes
• Ensure that unit test coverage remains above 80%
• Update all applicable documentation
• Follow Cluster Toolkit Contribution guidelines #

[gemini-code-assist]

Summary of Changes

Hello @parulbajaj01, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the NCCL gIB plugin installation process within the GKE A4x environment to be more configurable and adaptable. By converting the installer into a templated format and introducing new parameters, it allows for greater control over deployment specifics, such as rolling update behavior and node targeting, and explicitly supports different CPU architectures like ARM64. This change aims to improve the maintainability and versatility of the plugin's deployment.

Highlights

• NCCL gIB Plugin Parameterization: The NCCL gIB plugin installer has been significantly parameterized, allowing for dynamic configuration of deployment settings such as maxUnavailable for rolling updates and node affinity rules.
• Architecture-Specific Configuration: Introduced a target_architecture variable to support different gIB plugin versions for x86 and ARM64 architectures, enhancing flexibility for diverse hardware environments.
• Installer File Renaming and Templating: The nccl-rdma-installer.yaml file has been renamed to nccl-installer.yaml.tftpl and converted into a Terraform template, enabling variable substitution for image, version, and node affinity.
• Updated GKE A4x Configuration: The gke-a4x.yaml configuration now leverages the new templated installer, passing specific parameters for the gIB plugin, including the ARM64 target architecture, image details, and accelerator count.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively parameterizes the gIB NCCL plugin installer, transitioning from a static YAML file to a more flexible and reusable Terraform template. The changes introduce a dedicated gib configuration block within the kubectl-apply module, allowing for architecture-specific settings, as demonstrated in the gke-a4x example for arm64. My review includes a critical fix for an HCL syntax error in the new variable definition and a suggestion to further improve the module's design by reducing configuration redundancy.