Skip to content

Conversation

@simrankaurb
Copy link

This PR fixes an incorrect path in the Cloud Build configuration for the A3 MegaGPU tests.
The check_for_running_build step was erroneously pointing to tools/cloud-build/daily-tests/builds/ml-a3-mega-slurm-ubuntu.yaml. This has been corrected to tools/cloud-build/daily-tests/builds/ml-a3-megagpu-slurm-ubuntu.yaml.
This ensures the build check script references the correct YAML definition.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@simrankaurb simrankaurb requested review from a team and samskillman as code owners November 13, 2025 04:14
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @simrankaurb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the Cloud Build configuration for A3 MegaGPU tests was pointing to an incorrect YAML definition. By updating the script path, it ensures that the build check process correctly identifies and utilizes the intended configuration file, preventing potential build failures or misconfigurations related to the A3 MegaGPU test environment.

Highlights

  • Cloud Build Configuration Fix: Corrected an erroneous file path within the Cloud Build configuration for A3 MegaGPU tests.
  • Path Correction: The check_for_running_build step in ml-a3-megagpu-slurm-ubuntu.yaml was updated to reference ml-a3-megagpu-slurm-ubuntu.yaml instead of the incorrect ml-a3-mega-slurm-ubuntu.yaml.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes an incorrect path in the Cloud Build configuration for the A3 MegaGPU tests. The change is accurate and addresses the issue described. I've included one suggestion to replace the hardcoded file path with a Cloud Build substitution variable. This will make the configuration more robust and easier to maintain, preventing similar issues if the file is renamed or moved in the future.

- id: check_for_running_build
name: gcr.io/cloud-builders/gcloud
script: "tools/cloud-build/check_running_build.sh tools/cloud-build/daily-tests/builds/ml-a3-mega-slurm-ubuntu.yaml"
script: "tools/cloud-build/check_running_build.sh tools/cloud-build/daily-tests/builds/ml-a3-megagpu-slurm-ubuntu.yaml"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this change correctly fixes the path, you can make this more robust by using a Cloud Build substitution variable instead of a hardcoded path. This avoids having to manually update this line if the file is ever renamed or copied. Since the check_running_build.sh script already relies on the TRIGGER_BUILD_CONFIG_PATH substitution, you can use it here to pass the path.

  script: "tools/cloud-build/check_running_build.sh $_TRIGGER_BUILD_CONFIG_PATH"

@simrankaurb simrankaurb marked this pull request as draft November 13, 2025 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant