-
Notifications
You must be signed in to change notification settings - Fork 259
fix: Correct test build path for a3-megagpu in Cloud Build #4840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
fix: Correct test build path for a3-megagpu in Cloud Build #4840
Conversation
Summary of ChangesHello @simrankaurb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where the Cloud Build configuration for A3 MegaGPU tests was pointing to an incorrect YAML definition. By updating the script path, it ensures that the build check process correctly identifies and utilizes the intended configuration file, preventing potential build failures or misconfigurations related to the A3 MegaGPU test environment. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes an incorrect path in the Cloud Build configuration for the A3 MegaGPU tests. The change is accurate and addresses the issue described. I've included one suggestion to replace the hardcoded file path with a Cloud Build substitution variable. This will make the configuration more robust and easier to maintain, preventing similar issues if the file is renamed or moved in the future.
| - id: check_for_running_build | ||
| name: gcr.io/cloud-builders/gcloud | ||
| script: "tools/cloud-build/check_running_build.sh tools/cloud-build/daily-tests/builds/ml-a3-mega-slurm-ubuntu.yaml" | ||
| script: "tools/cloud-build/check_running_build.sh tools/cloud-build/daily-tests/builds/ml-a3-megagpu-slurm-ubuntu.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this change correctly fixes the path, you can make this more robust by using a Cloud Build substitution variable instead of a hardcoded path. This avoids having to manually update this line if the file is ever renamed or copied. Since the check_running_build.sh script already relies on the TRIGGER_BUILD_CONFIG_PATH substitution, you can use it here to pass the path.
script: "tools/cloud-build/check_running_build.sh $_TRIGGER_BUILD_CONFIG_PATH"
This PR fixes an incorrect path in the Cloud Build configuration for the A3 MegaGPU tests.
The
check_for_running_buildstep was erroneously pointing totools/cloud-build/daily-tests/builds/ml-a3-mega-slurm-ubuntu.yaml. This has been corrected totools/cloud-build/daily-tests/builds/ml-a3-megagpu-slurm-ubuntu.yaml.This ensures the build check script references the correct YAML definition.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.