-
Notifications
You must be signed in to change notification settings - Fork 259
feat: Add Gemini Code Assist Customization #4820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat: Add Gemini Code Assist Customization #4820
Conversation
6768282 to
e40a2ce
Compare
|
/gemini review |
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
e40a2ce to
b577b32
Compare
.gemini/styleguide.md
Outdated
| 1. **Blueprint Authoring (YAML):** | ||
| * Ensure the `use` block is preferred for module dependencies within blueprints. Explicit variable linking (e.g., `setting = $(module.output)`) should only be used when necessary to resolve ambiguity. | ||
| * Verify that module sources are correct and the referenced modules exist. | ||
| * Check for logical grouping of modules within `deployment_groups`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should define the logical groupings based on module types eg) network, storage, cluster etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logical groups for deployment_groups is not defined. You have only added the folder definitions for modules here - 778c7a0#diff-2d64e32e0ed73fabd653270b96703ac45c54f710133a9ed5882c6d0c6efe6f32L24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh, I see. I am not sure how we should guide it at this point as I am not sure how we can guide an agent to find logical deployment groups...
b577b32 to
70f22ce
Compare
Updates the Terraform module development guidelines to ensure new modules are placed in the correct subdirectory within `modules/` or `community/modules/.
feat: Add Gemini Code Assist Customization
This PR introduces a customization for the Gemini Code Assist on GitHub to improve the quality and consistency of automated code reviews for the Cluster Toolkit.
By adding a
.gemini/directory with astyleguide.mdand a defaultconfig.yaml, we provide Gemini with specific instructions and context about the Cluster Toolkit's best practices, structure, and documentation requirements.The
styleguide.mdemphasizes:useblock, module sourcing).modules/README.md,examples/README.md) when new modules/examples are added.This customization aims to make Gemini Code Assist reviews more relevant and helpful, catching potential issues early and reinforcing project conventions.