fix: Multi-Approvers Workflow #4799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neelabh94
added
release-chore
SwarnaBharathiMantena
previously approved these changes
Oct 30, 2025
Contributor
SwarnaBharathiMantena
left a comment
SwarnaBharathiMantena
left a comment
There was a problem hiding this comment.
Please test the multi-approvers workflow once the merge is completed.
Neelabh94
force-pushed
the
feature/update-multi-approver-workflow
branch
from
59adce3 to
6c257b2
Compare
Neelabh94
force-pushed
the
feature/update-multi-approver-workflow
branch
from
6c257b2 to
9c90db2
Compare
Neelabh94
changed the title
bytetwin
reviewed
Nov 13, 2025
Collaborator
bytetwin
left a comment
bytetwin
left a comment
There was a problem hiding this comment.
This change triggers multi approvers only when the event_name is pr_review (refer line 43). Do we need to trigger for event_name = pr ?
Neelabh94
force-pushed
the
feature/update-multi-approver-workflow
branch
from
2f3f171 to
7b7226f
Compare
SwarnaBharathiMantena
approved these changes
Nov 13, 2025
Contributor
SwarnaBharathiMantena
left a comment
SwarnaBharathiMantena
left a comment
There was a problem hiding this comment.
LGTM
Note: This will bring back the initial reason why this file was modified, that is the requirement that the PR test for pull request will not automatically run and will need a manual run click.
Neelabh94
merged commit 40eee2d
into
GoogleCloudPlatform:develop
13 of 67 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-introduces the hook to trigger multi-approver workflow when a new PR is opened and returns to the old workflow as it was before the 13th of October 2025.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.