Skip to content

Conversation

@ankitkumar-quad
Copy link
Contributor

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

arpit974 and others added 7 commits October 10, 2025 07:33
Updated the instance_image.family in a3ultra-vm.yaml to use ubuntu-accelerator-2204-amd64-with-nvidia-570 instead of nvidia-550 for improved compatibility and performance.
Add a variable to skip the machine-type validation for TPUs
@ankitkumar-quad ankitkumar-quad requested review from a team and samskillman as code owners October 21, 2025 08:08
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ankitkumar-quad, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on updating the version of the HPC Toolkit to v1.69.0 across its core command-line tool and numerous Terraform modules. A significant functional enhancement is also included, which modifies the GKE node pool module to bypass machine-type validation for TPU reservations, improving flexibility for TPU-based deployments.

Highlights

  • Version Update: The HPC Toolkit's core command-line tool and numerous associated Terraform modules have been updated to version v1.69.0.
  • GKE Node Pool TPU Reservation Logic: The GKE node pool module now includes logic to conditionally bypass machine-type validation for aggregate TPU reservations, enhancing flexibility for TPU-based deployments.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ankitkumar-quad ankitkumar-quad added the release-chore To not include into release notes label Oct 21, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily consists of a version bump from v1.68.0 to v1.69.0 across numerous modules. It also includes a small enhancement in the gke-node-pool module to bypass reservation validation for TPUs. My review has identified a potential inconsistency in two GKE-related modules (gke-node-pool and gke-cluster) where the module_name for the google-beta provider was not updated along with the google provider. I've left specific comments with suggestions to update these for consistency if it was an oversight.

@ankitkumar-quad ankitkumar-quad merged commit 6c1e2a0 into develop Oct 21, 2025
16 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-chore To not include into release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants