Skip to content

Conversation

@kgala2
Copy link
Contributor

@kgala2 kgala2 commented Mar 28, 2025

This PR enables private IP tests for Cloud SQL instances with the help of Cloud Build private pool

Introduced a new environment variable - IP_TYPE which is set as "PRIVATE" for PSA tests in the cloudbuild.yaml file

Before reviewing this PR, please review: #433

@kgala2 kgala2 requested a review from a team as a code owner March 28, 2025 23:47
@kgala2
Copy link
Contributor Author

kgala2 commented Apr 1, 2025

/gcbrun

@kgala2 kgala2 closed this Apr 2, 2025
@kgala2 kgala2 force-pushed the test-cloudbuild-integration branch from 8a8469e to 3d8c3ac Compare April 2, 2025 17:59
@kgala2 kgala2 reopened this Apr 2, 2025
Copy link
Collaborator

@jackwotherspoon jackwotherspoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jackwotherspoon jackwotherspoon changed the title build: add cloudbuild config for PSA tests ci: add cloudbuild config for PSA tests Apr 2, 2025
@kgala2 kgala2 merged commit 95fadda into main Apr 2, 2025
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants