Skip to content

test: update ip type for connectors #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgala2 merged 12 commits into from
Apr 2, 2025
Merged

test: update ip type for connectors #433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
edb78bb
chore: update gitignore and add cloudbuild yaml
kgala2 Mar 28, 2025
61bdc79
chore: update nodejs version
kgala2 Mar 28, 2025
0e47c45
chore: update ipType to env variable
kgala2 Mar 28, 2025
191e78a
chore: add unit and sample tests
kgala2 Mar 28, 2025
490442d
chore: update cloudbuild.yaml
kgala2 Mar 28, 2025
c96fcc9
chore: update test structure
kgala2 Mar 28, 2025
02f62f4
chore: remove independent test execution
kgala2 Mar 28, 2025
5acb6ec
chore: update test call format
kgala2 Mar 28, 2025
a24bce2
chore: remove cloudbuild file
kgala2 Mar 28, 2025
54f191f
chore: update ipType for all system tests
kgala2 Apr 1, 2025
f650ed2
chore: update iptype for pg-connect and tedious-connect
kgala2 Apr 1, 2025
87f7553
Update .gitignore
kgala2 Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,4 @@
!/.trampolinerc
!/.kokoro
!/tsconfig*.json
!/.ci
4 changes: 2 additions & 2 deletions system-test/mysql2-connect.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ t.test('open connection and run basic mysql commands', async t => {
const connector = new Connector();
const clientOpts = await connector.getOptions({
instanceConnectionName: process.env.MYSQL_CONNECTION_NAME,
ipType: 'PUBLIC',
ipType: process.env.IP_TYPE || 'PUBLIC',
authType: 'PASSWORD',
});
const conn = await mysql.createConnection({
Expand All @@ -42,7 +42,7 @@ t.test('open IAM connection and run basic mysql commands', async t => {
const connector = new Connector();
const clientOpts = await connector.getOptions({
instanceConnectionName: process.env.MYSQL_CONNECTION_NAME,
ipType: 'PUBLIC',
ipType: process.env.IP_TYPE || 'PUBLIC',
authType: 'IAM',
});
const conn = await mysql.createConnection({
Expand Down
4 changes: 2 additions & 2 deletions system-test/mysql2-connect.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ t.test('open connection and run basic mysql commands', async t => {
const connector = new Connector();
const clientOpts = await connector.getOptions({
instanceConnectionName: process.env.MYSQL_CONNECTION_NAME,
ipType: 'PUBLIC',
ipType: process.env.IP_TYPE || 'PUBLIC',
authType: 'PASSWORD',
});
const conn = await mysql.createConnection({
Expand All @@ -42,7 +42,7 @@ t.test('open IAM connection and run basic mysql commands', async t => {
const connector = new Connector();
const clientOpts = await connector.getOptions({
instanceConnectionName: process.env.MYSQL_CONNECTION_NAME,
ipType: 'PUBLIC',
ipType: process.env.IP_TYPE || 'PUBLIC',
authType: 'IAM',
});
const conn = await mysql.createConnection({
Expand Down
3 changes: 2 additions & 1 deletion system-test/mysql2-connect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ t.test('open connection and run basic mysql commands', async t => {
const connector = new Connector();
const clientOpts = await connector.getOptions({
instanceConnectionName: String(process.env.MYSQL_CONNECTION_NAME),
ipType: process.env.IP_TYPE || IpAddressTypes.PUBLIC,
});
const conn = await mysql.createConnection({
...clientOpts,
Expand All @@ -50,7 +51,7 @@ t.test('open IAM connection and run basic mysql commands', async t => {
const connector = new Connector();
const clientOpts = await connector.getOptions({
instanceConnectionName: String(process.env.MYSQL_CONNECTION_NAME),
ipType: IpAddressTypes.PUBLIC,
ipType: process.env.IP_TYPE || IpAddressTypes.PUBLIC,
authType: AuthTypes.IAM,
});
const conn = await mysql.createConnection({
Expand Down
7 changes: 6 additions & 1 deletion system-test/pg-connect.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ t.test('open connection and retrieves standard pg tables', async t => {
const connector = new Connector();
const clientOpts = await connector.getOptions({
instanceConnectionName: process.env.POSTGRES_CONNECTION_NAME,
ipType: process.env.IP_TYPE || 'PUBLIC',
});
const client = new Client({
...clientOpts,
Expand Down Expand Up @@ -49,7 +50,7 @@ t.test('open IAM connection and retrieves standard pg tables', async t => {
const connector = new Connector();
const clientOpts = await connector.getOptions({
instanceConnectionName: process.env.POSTGRES_CONNECTION_NAME,
ipType: 'PUBLIC',
ipType: process.env.IP_TYPE || 'PUBLIC',
authType: 'IAM',
});
const client = new Client({
Expand Down Expand Up @@ -79,6 +80,7 @@ t.test(
const connector = new Connector();
const clientOpts = await connector.getOptions({
instanceConnectionName: String(process.env.POSTGRES_CAS_CONNECTION_NAME),
ipType: process.env.IP_TYPE || 'PUBLIC',
});
const client = new Client({
...clientOpts,
Expand Down Expand Up @@ -112,6 +114,7 @@ t.test(
instanceConnectionName: String(
process.env.POSTGRES_CUSTOMER_CAS_CONNECTION_NAME
),
ipType: process.env.IP_TYPE || 'PUBLIC',
});
const client = new Client({
...clientOpts,
Expand Down Expand Up @@ -142,6 +145,7 @@ t.test(
const connector = new Connector();
const clientOpts = await connector.getOptions({
domainName: String(process.env.POSTGRES_CUSTOMER_CAS_DOMAIN_NAME),
ipType: process.env.IP_TYPE || 'PUBLIC',
});
const client = new Client({
...clientOpts,
Expand Down Expand Up @@ -172,6 +176,7 @@ t.test(
const connector = new Connector();
const clientOpts = await connector.getOptions({
domainName: String(process.env.POSTGRES_CUSTOMER_CAS_INVALID_DOMAIN_NAME),
ipType: process.env.IP_TYPE || 'PUBLIC',
});
const client = new Client({
...clientOpts,
Expand Down
7 changes: 6 additions & 1 deletion system-test/pg-connect.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ t.test('open connection and retrieves standard pg tables', async t => {
const connector = new Connector();
const clientOpts = await connector.getOptions({
instanceConnectionName: String(process.env.POSTGRES_CONNECTION_NAME),
ipType: process.env.IP_TYPE || 'PUBLIC',
});
const client = new Client({
...clientOpts,
Expand Down Expand Up @@ -50,7 +51,7 @@ t.test('open IAM connection and retrieves standard pg tables', async t => {
const connector = new Connector();
const clientOpts = await connector.getOptions({
instanceConnectionName: String(process.env.POSTGRES_CONNECTION_NAME),
ipType: 'PUBLIC',
ipType: process.env.IP_TYPE || 'PUBLIC',
authType: 'IAM',
});
const client = new Client({
Expand Down Expand Up @@ -80,6 +81,7 @@ t.test(
const connector = new Connector();
const clientOpts = await connector.getOptions({
instanceConnectionName: String(process.env.POSTGRES_CAS_CONNECTION_NAME),
ipType: process.env.IP_TYPE || 'PUBLIC',
});
const client = new Client({
...clientOpts,
Expand Down Expand Up @@ -113,6 +115,7 @@ t.test(
instanceConnectionName: String(
process.env.POSTGRES_CUSTOMER_CAS_CONNECTION_NAME
),
ipType: process.env.IP_TYPE || 'PUBLIC',
});
const client = new Client({
...clientOpts,
Expand Down Expand Up @@ -143,6 +146,7 @@ t.test(
const connector = new Connector();
const clientOpts = await connector.getOptions({
domainName: String(process.env.POSTGRES_CUSTOMER_CAS_DOMAIN_NAME),
ipType: process.env.IP_TYPE || 'PUBLIC',
});
const client = new Client({
...clientOpts,
Expand Down Expand Up @@ -173,6 +177,7 @@ t.test(
const connector = new Connector();
const clientOpts = await connector.getOptions({
domainName: String(process.env.POSTGRES_CUSTOMER_CAS_INVALID_DOMAIN_NAME),
ipType: process.env.IP_TYPE || 'PUBLIC',
});
const client = new Client({
...clientOpts,
Expand Down
7 changes: 6 additions & 1 deletion system-test/pg-connect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ t.test('open connection and retrieves standard pg tables', async t => {
const connector = new Connector();
const clientOpts = await connector.getOptions({
instanceConnectionName: String(process.env.POSTGRES_CONNECTION_NAME),
ipType: process.env.IP_TYPE || IpAddressTypes.PUBLIC,
});
const client = new Client({
...clientOpts,
Expand Down Expand Up @@ -53,7 +54,7 @@ t.test('open IAM connection and retrieves standard pg tables', async t => {
const connector = new Connector();
const clientOpts = await connector.getOptions({
instanceConnectionName: String(process.env.POSTGRES_CONNECTION_NAME),
ipType: IpAddressTypes.PUBLIC,
ipType: process.env.IP_TYPE || IpAddressTypes.PUBLIC,
authType: AuthTypes.IAM,
});
const client = new Client({
Expand Down Expand Up @@ -83,6 +84,7 @@ t.test(
const connector = new Connector();
const clientOpts = await connector.getOptions({
instanceConnectionName: String(process.env.POSTGRES_CAS_CONNECTION_NAME),
ipType: process.env.IP_TYPE || IpAddressTypes.PUBLIC,
});
const client = new Client({
...clientOpts,
Expand Down Expand Up @@ -116,6 +118,7 @@ t.test(
instanceConnectionName: String(
process.env.POSTGRES_CUSTOMER_CAS_CONNECTION_NAME
),
ipType: process.env.IP_TYPE || IpAddressTypes.PUBLIC,
});
const client = new Client({
...clientOpts,
Expand Down Expand Up @@ -146,6 +149,7 @@ t.test(
const connector = new Connector();
const clientOpts = await connector.getOptions({
domainName: String(process.env.POSTGRES_CUSTOMER_CAS_DOMAIN_NAME),
ipType: process.env.IP_TYPE || IpAddressTypes.PUBLIC,
});
const client = new Client({
...clientOpts,
Expand Down Expand Up @@ -176,6 +180,7 @@ t.test(
const connector = new Connector();
const clientOpts = await connector.getOptions({
domainName: String(process.env.POSTGRES_CUSTOMER_CAS_INVALID_DOMAIN_NAME),
ipType: process.env.IP_TYPE || IpAddressTypes.PUBLIC,
});
const client = new Client({
...clientOpts,
Expand Down
2 changes: 1 addition & 1 deletion system-test/tedious-connect.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ t.test('open connection and run basic sqlserver commands', async t => {
const connector = new Connector();
const clientOpts = await connector.getTediousOptions({
instanceConnectionName: process.env.SQLSERVER_CONNECTION_NAME,
ipType: 'PUBLIC',
ipType: process.env.IP_TYPE || 'PUBLIC',
});
const connection = new Connection({
server: '0.0.0.0',
Expand Down
2 changes: 1 addition & 1 deletion system-test/tedious-connect.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ t.test('open connection and run basic sqlserver commands', async t => {
const connector = new Connector();
const clientOpts = await connector.getTediousOptions({
instanceConnectionName: process.env.SQLSERVER_CONNECTION_NAME,
ipType: 'PUBLIC',
ipType: process.env.IP_TYPE || 'PUBLIC',
});
const connection = new Connection({
server: '0.0.0.0',
Expand Down
2 changes: 1 addition & 1 deletion system-test/tedious-connect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ t.test('open connection and run basic sqlserver commands', async t => {
const connector = new Connector();
const clientOpts = await connector.getTediousOptions({
instanceConnectionName: String(process.env.SQLSERVER_CONNECTION_NAME),
ipType: IpAddressTypes.PUBLIC,
ipType: process.env.IP_TYPE || IpAddressTypes.PUBLIC,
});
const connection = new Connection({
server: '0.0.0.0',
Expand Down
Loading