feat: Use standard TLS hostname validation for instances with DNS names #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
The NodeJS SqlAdmin library has not yet been released. This PR will not be ready for review until after the next NodeJS API release. |
hessjcg
force-pushed
the
cas-dns-names-field
branch
4 times, most recently
from
e86b449 to
74fc754
Compare
hessjcg
force-pushed
the
cas-dns-names-field
branch
from
74fc754 to
bedde48
Compare
hessjcg
changed the title
src/sqladmin-fetcher.ts
Outdated
| // also set the dnsName field. | ||
| if (dnsName && pscEnabled) { | ||
| ipAddresses.psc = dnsName; | ||
| if (pscEnabled) { |
Collaborator
There was a problem hiding this comment.
are we still supposed to check for pscEnabled?
Collaborator
Author
There was a problem hiding this comment.
Updated. I think we are checking if pscEnabled but only for the dnsName field.
hessjcg
force-pushed
the
cas-dns-names-field
branch
from
bedde48 to
abec09a
Compare
…er certificate's server name.
hessjcg
force-pushed
the
cas-dns-names-field
branch
from
abec09a to
795e092
Compare
jackwotherspoon
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the the Cloud SQL Instance reports that it has a DNS Name, the connector will use standard TLS hostname validation when checking the server certificate. Now, the server's TLS certificate must contain a SAN record with the instance's DNS name.
The ConnectSettings API added a field dns_names which contains all of the valid DNS names for
an instance.
See also: GoogleCloudPlatform/cloud-sql-go-connector#954