Skip to content

Conversation

@frandarre14
Copy link

Working on a project with @mauriciowillig we've noticed that the spanner_instance module was not passing the variable to the Spanner Instance Database resource within, so it was defaulting on creating the database with GOOGLE_CLOUD_SQL dialect and ignoring POSTGRES even if added as a module variable.

We've also noticed that there was no support to input instance settings like database edition, type and default backup schedule type, so we've added those as well.


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@frandarre14
Copy link
Author

Will add defaults on next commit to prevent failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants