Skip to content

Conversation

@jrmccluskey
Copy link
Contributor

Increment the Beam version to address a potential mismatch in submission environment dependencies vs runtime dependencies.

@jrmccluskey jrmccluskey requested a review from a team as a code owner November 26, 2025 15:12
@gemini-code-assist
Copy link

Summary of Changes

Hello @jrmccluskey, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a critical dependency upgrade within the datastream-mongodb-to-firestore project. By incrementing the Apache Beam version, the change ensures greater stability and compatibility, preventing potential issues that could arise from differing dependency versions between the environment where the job is submitted and where it actually runs.

Highlights

  • Apache Beam Version Update: The Apache Beam dependency for beam-runners-direct-java has been updated from version 2.66.0 to 2.69.0.
  • Dependency Mismatch Resolution: This version bump aims to address and resolve potential mismatches between submission environment dependencies and runtime dependencies.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.25%. Comparing base (cdb6373) to head (6e947e9).
⚠️ Report is 119 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3028      +/-   ##
============================================
+ Coverage     49.98%   50.25%   +0.27%     
- Complexity     4955     5397     +442     
============================================
  Files           967      967              
  Lines         59253    59268      +15     
  Branches       6431     6458      +27     
============================================
+ Hits          29615    29787     +172     
+ Misses        27538    27376     -162     
- Partials       2100     2105       +5     
Components Coverage Δ
spanner-templates 70.44% <ø> (+0.07%) ⬆️
spanner-import-export 68.98% <ø> (+0.25%) ⬆️
spanner-live-forward-migration 79.69% <ø> (-0.05%) ⬇️
spanner-live-reverse-replication 77.07% <ø> (-0.36%) ⬇️
spanner-bulk-migration 88.33% <ø> (+0.12%) ⬆️
see 53 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@baeminbo
Copy link

@jrmccluskey, Hi, upgrading with a hard-coded version will cause a potential conflict in the future. I suggest ${beam.version} at #3026 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants