-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix TrimmedShardedDataChangeRecord to use AvroCoder everywhere in the template. #2993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix TrimmedShardedDataChangeRecord to use AvroCoder everywhere in the template. #2993
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2993 +/- ##
============================================
+ Coverage 50.19% 50.24% +0.05%
- Complexity 5000 5018 +18
============================================
Files 966 967 +1
Lines 59163 59260 +97
Branches 6449 6458 +9
============================================
+ Hits 29695 29777 +82
- Misses 27367 27377 +10
- Partials 2101 2106 +5
🚀 New features to boost your workflow:
|
manitgupta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the description with the Testing section detailing the tests that you have run?
...main/java/com/google/cloud/teleport/v2/templates/changestream/encoder/TimestampEncoding.java
Outdated
Show resolved
Hide resolved
|
I think you can close this PR for now since we need to do a round of functional and load testing before we can merge this. |
b/459651641
Problem
We currently use SerializableCoder in Reverse Replication template which is quite slow and is contributing to the OOMs we've been seeing while running reverse jobs.
Fix
Fix TrimmedShardedDataChangeRecord to use AvroCoder everywhere in the template.