Flink 2.1 - Source for Datastream/Table APIs #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/gcbrun |
prashastia
reviewed
Nov 16, 2025
| () -> new BigQuerySourceSplitReader(getReadOptions(), bqReaderContext); | ||
|
|
||
| return new BigQuerySourceReader<>( | ||
| splitReaderSupplier, |
Collaborator
There was a problem hiding this comment.
The change is due to update in the constructor for SingleThreadMultiplexSourceReaderBase in flink 2.1 right? The elementsQueue is no longer supported?
| return new BigQuerySourceReader<>( | ||
| splitReaderSupplier, | ||
| new BigQueryRecordEmitter<>(getDeserializationSchema()), | ||
| bqReaderContext); |
Collaborator
There was a problem hiding this comment.
In the absence of a custom blocking queue. what does the value default to?
prashastia
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out the changes needed for support BigQuerySource for the Datastream/Table APIs from the original PR: #234
While this PR appears large, the actual changes are quite minimal. The first commit simply copies files from flink-1.17-connector-bigquery to a new flink-2.1-connector-bigquery directory and can be skipped during review. In the subsequent commits, I actually make changes to those files so those commits are worth reviewing and if you review commit-by-commit it will be easy to see what has actually changed.
The files that have actually changed: