BigQuery API not enabled - Customer Issue fixed.

[srinivasan-acn]

The Health Check API was not configured to retrieve the Custom Domain URL from G-cloud. Provided a fix for the same.

[gemini-code-assist]

Summary of Changes

Hello @srinivasan-acn, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a customer-reported issue where the BigQuery API's enabled status was not being accurately determined by the Health Check API. The primary fix involves enhancing the service enablement check to correctly resolve and use the full domain name for GCP services, ensuring that gcloud commands can properly identify and verify API status. This change specifically rectifies the BigQuery API detection problem by ensuring the health check mechanism can retrieve and process the custom domain URL from G-cloud.

Highlights

• Service API Check Logic Update: The logic for checking if a GCP API service is enabled has been updated to correctly retrieve and utilize the full domain name (e.g., 'bigquery.googleapis.com') when executing gcloud services list commands. This resolves an issue where the service name format was incorrect for the gcloud filter.
• BigQuery Service URL Integration: The BigQuery service URL is now properly integrated into the application's URL mapping utility, making its domain accessible for health checks and other related operations.
• Service Name Constant Refinement: Constants for DATAPROC_SERVICE_NAME and BIGQUERY_SERVICE_NAME in src/utils/const.ts have been refined to use short service names (e.g., 'bigquery') instead of full domain names. This change aligns with the expected input format for the gcp_service_url function, which constructs the complete service URL.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses an issue with checking if the BigQuery API is enabled, particularly for users with custom domain URLs. The changes correctly modify the logic to first resolve the service name to its full URL and then parse the domain for the gcloud command. The frontend constants are also updated to pass the short service name as expected by the backend.

My review includes two suggestions for improvement in dataproc_jupyter_plugin/controllers/checkApiEnabled.py:

1. A more robust method for parsing the service domain from the URL to handle various URL formats correctly.
2. An improvement to an error message to make it more informative when a service URL cannot be resolved.

Overall, the changes are in the right direction to fix the reported customer issue.