-
Notifications
You must be signed in to change notification settings - Fork 16
Filter jupyter templates as part of runtime templates listing #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Filter jupyter templates as part of runtime templates listing #313
Conversation
Summary of ChangesHello @aditee-accenture, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Dataproc Jupyter plugin by refining the display of runtime templates. The change introduces a filter to ensure that only Jupyter-compatible templates are presented to the user, addressing the current limitation where Jupyter Lab does not support Spark Connect templates. This modification streamlines the user interface by providing a more focused and relevant list of available templates. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly filters runtime templates to only show Jupyter templates, which aligns with the stated goal. My review includes suggestions to improve type safety in the function signature, which in turn simplifies the code by removing the need for type casting. I've also identified a couple of opportunities to remove redundancy for cleaner and more maintainable code.
| pageSize: '50', | ||
| pageToken: pageToken | ||
| }); | ||
| renderActions: (value: ISessionTemplate) => React.JSX.Element, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please undo the formatting related changes in this file.
Currently dataproc jupyter plugin lists both jupyter and spark connect templates as part of runtime templates listing.
Modify the code to diplay only jupyter templates as Jupyter lab does not support spark connect templates at this point