Batches-network-loader-fix

[aditee-accenture]

In Create Batch UI, when a network is changed, loader appears for both primary network and subnetwork sections.

[gemini-code-assist]

Summary of Changes

Hello @aditee-accenture, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the user interface for creating batches by enhancing the display of loading states when fetching network and subnetwork configurations. It introduces separate loading indicators for network and subnetwork dropdowns, ensuring a clearer visual cue for users during data retrieval. Additionally, the underlying API service for listing networks has been refactored for more robust error handling and consistent loader dismissal.

Highlights

• Separate Loading States: Introduced distinct loading state variables and logic for network and subnetwork fetching, allowing for independent visual feedback during data retrieval.
• Enhanced Network API Error Handling: Refactored the network listing API service to use try...catch...finally for more robust error handling and guaranteed dismissal of loading indicators, improving reliability.
• Inline Loading Indicators: Implemented a new helper function to display inline loading spinners next to the 'Primary network' and 'Subnetwork' labels, providing a more integrated and user-friendly loading experience.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses the UI issue where a single loader was shown for both network and subnetwork selection. By introducing a separate state for subnetwork loading (isloadingSubNetwork), the user experience is improved. The refactoring of listNetworksAPIService to use async/await is a welcome change that enhances code readability.

I have provided a couple of review comments:

1. A critical fix in batchService.tsx to prevent a potential type error when the network list is empty.
2. A medium-severity suggestion in createBatch.tsx to simplify the JSX by removing a redundant React Fragment.

Overall, the changes are good and move in the right direction.