refactor: use GDRE for self setup #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the setup to a setup scene. This setup scene is loaded by the `--script`.
This reverts commit 95ce66c.
Qubus0
reviewed
Feb 16, 2025
Collaborator
Qubus0
left a comment
Qubus0
left a comment
There was a problem hiding this comment.
this did not include gdre in the commit - i assume that changes the steps required for the setup? could you add those to the description for testing?
KANAjetzt
changed the title
This was referenced Jun 10, 2025
Collaborator
|
Attached zip was successfully tested an windows by three people from our discord 👍 we'll bring other platform support later |
Qubus0
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Currently, self-setup (and Mod Hooks in general) only works if the game exports GDScript in plain text. Before Godot 4.3, this is always the case.
Note
Injection is currently only supported for Windows.
This PR replaces PckExplorer with GDRE.
Tested With
Downloads
Download the zip file for your operating system and unpack the
addonsdirectory next to the game executable.ModLoader-Self-Setup_7.0.0-WIN.zip