-
Notifications
You must be signed in to change notification settings - Fork 44
refactor: ♻️ 4.1 support #508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
_ModLoaderModHookPreProcessor.fix_method_super() erased everything after the function body, leaving only the first function in a script.
Qubus0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, ty.
the resources might get annoying since they will always want to be saved in the newer format version.
we might also want to consider an engine version test that just runs --check-only on each of our scripts for every version we want to support in order to avoid accidentally using things like typed loop variables.
Co-authored-by: steen <[email protected]>
supersedes #441
Original PR Description:
Todos