This repository was archived by the owner on Sep 13, 2022. It is now read-only.
Always show ex logo at sponsored gyms#67
Closed
hammydown4325 wants to merge 3 commits intoGlennmen:developfrom
Closed
Always show ex logo at sponsored gyms#67hammydown4325 wants to merge 3 commits intoGlennmen:developfrom
hammydown4325 wants to merge 3 commits intoGlennmen:developfrom
Conversation
CalamityJames
approved these changes
Jan 19, 2018
Collaborator
CalamityJames
left a comment
CalamityJames
left a comment
There was a problem hiding this comment.
The code seems fine, however I cannot test this in my real world environment as we do not have sponsored gyms here.
Glennmen
reviewed
Jan 19, 2018
static/js/map.js
Outdated
| } | ||
| var exIcon = '' | ||
| if ((((park !== 'None' && park !== undefined && onlyTriggerGyms === false && park) || triggerGyms.includes(item['gym_id'])) && (noExGyms === false))) { | ||
| if ((((park !== 'None' && park !== undefined && onlyTriggerGyms === false && park) || item['sponsor'] > 0 || triggerGyms.includes(item['gym_id'])) && (noExGyms === false))) { |
Owner
There was a problem hiding this comment.
How does it handle if item['sponsor'] is not set/undefined?
Contributor
Author
|
Good thinking. We could use more of that type of logic throughout the map.js file anyway let me add an !== Undefined real quick |
Owner
|
@iroken222 Can you fix the merge conflict, thanks. |
Owner
|
This seems to have already been included in PR #54 so this PR can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made it so sponsored gyms are always shown as EX Raid Compatible. Some are not showing up for some people.