This repository was archived by the owner on Sep 13, 2022. It is now read-only.
Notify on 0 iv toggle switch#52
Open
thermoscookies wants to merge 12 commits intoGlennmen:developfrom
thermoscookies:notify0iv
Open
Notify on 0 iv toggle switch#52thermoscookies wants to merge 12 commits intoGlennmen:developfrom thermoscookies:notify0iv
thermoscookies wants to merge 12 commits intoGlennmen:developfrom
thermoscookies:notify0iv
Conversation
…php or map.common.js
thermoscookies
changed the title
Glennmen
suggested changes
Jan 4, 2018
Owner
Glennmen
left a comment
Glennmen
left a comment
There was a problem hiding this comment.
Also please fix travis error (indentation)
static/js/map.js
Outdated
| marker.setAnimation(google.maps.Animation.BOUNCE) | ||
| } | ||
| } | ||
| if (Store.get('remember_show_ivzero') && perfection < 1) { |
Owner
There was a problem hiding this comment.
Would perfection < 1 be good enough? What if the IV is 0.5% (not sure if this is possible).
Closed
chaned 'perfection < 1' to 'perfection == 0'
Author
|
I'm still learning how to use git, but I changed 'perfection < 1' to 'perfection === 0' and travis seems to be happy and the 0's still bounce. |
Glennmen
approved these changes
Jan 5, 2018
Glennmen
suggested changes
Jan 7, 2018
| } | ||
| } | ||
| if (Store.get('remember_show_ivzero') && perfection === 0) { | ||
| if (marker.animationDisabled !== true) { |
Owner
There was a problem hiding this comment.
This PR will only make the markers bounce, it will not send a notification. Is this intended or a mistake?
replaced Store.get call with $selectnotifiyIvZero & enabled notifications for 0 iv's
Author
|
@Glennmen do you see anything else you would like me to change for this pr? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some users want to be notified of 0iv pokemon so this PR allows them to bounce separate from the other minimum iv notification since setting it to 0 would make everything bounce.