feat(scripts): Update the publish script #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the publish extractor pack script to automatically detect and configure the CodeQL binary, and enables query pack creation that was previously commented out.
- Adds automatic detection and installation of CodeQL binary (standalone or via gh extension)
- Uncomments and updates the query pack creation commands to output to
./extractor-pack/qlpacksdirectory - Creates both library and source query packs as part of the publishing process
| CODEQL_BINARY="gh codeql" | ||
| else | ||
| gh extension install github/gh-codeql | ||
| CODEQL_BINARY="gh codeql" |
There was a problem hiding this comment.
If the gh-codeql extension installation fails, the script will continue executing and may fail later when trying to use $CODEQL_BINARY. Consider adding error handling to check if the installation succeeded.
Suggested change
| CODEQL_BINARY="gh codeql" | |
| if gh codeql >/dev/null; then | |
| CODEQL_BINARY="gh codeql" | |
| else | |
| echo "[!] Failed to install gh-codeql extension or 'gh codeql' is not available." | |
| exit 1 | |
| fi |
Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.