Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on fixing the memory leak issue in DuckDBResult struct (#280).
Plan:
using
statements due to struct copying behaviorRoot Cause:
The issue is that
DuckDBResult
is astruct
implementingIDisposable
. When used in ausing
statement, C# creates a copy of the struct, andDispose()
is called on the copy, not the original. This means the native memory pointed to byIntPtr internal_data
is not properly freed, causing memory leaks.Solution:
Remove
IDisposable
from the struct and provide alternative mechanisms for resource cleanup that work correctly with struct semantics.Fixes #280.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.