Skip to content

Should the RuntimeIdentifiers property osx change to osx-x64? #201

Closed

Description

@Cricle

<RuntimeIdentifiers>win-x64;linux-x64;linux-arm64;osx</RuntimeIdentifiers>

<MSBuild Projects="DownloadNativeLibs.targets" Properties="Rid=osx;LibUrl=$(DuckDbArtifactRoot)/libduckdb-osx-universal.zip" />

According to rid-catalog#macos osx-x64 is macOS RIDs

Activity

  1. Cricle commented on Jun 19, 2024

    @Cricle
    ContributorAuthor

    Drafted modifications on #202

  2. Giorgi commented on Jun 19, 2024

    @Giorgi
    Owner

    In that case I would need to have osx-x64 and osx-arm64 which probably means including libduckdb.dylib twice in the NuGet package.

  3. Cricle commented on Jun 19, 2024

    @Cricle
    ContributorAuthor

    When use osx in RuntimeIdentifiers property in publish with AOT option will throw this error

    Error NETSDK1082: Microsoft. NETCore. App does not have a runtime package available for the specified RuntimeIdentifier 'osx'
    

    The public PortableRuntimeIdentifierGraph in here

    https://github.com/dotnet/sdk/blob/cfab4700816a8ace11b9b700a1d85b721c363d6a/src/Layout/redist/PortableRuntimeIdentifierGraph.json#L317-L333

    I don't know if this OSX identity will continue to be used in the future, If this is an unimportant matter, please close this issue.

    Thanks.

  4. Giorgi commented on Jun 19, 2024

    @Giorgi
    Owner

    I haven't looked into Native AOT yet. I'll close this issue and we can come back to it if needed.

  5. Cricle commented on Jun 19, 2024

    @Cricle
    ContributorAuthor

    Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions