Fix Cape Elytra textures #5968
Open
Fix Cape Elytra textures #5968
+22
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oryxel1
reviewed
Nov 5, 2025
| packet.setOldSkinName(""); | ||
| packet.setNewSkinName(skin.textureUrl()); | ||
| packet.setSkin(getSkin(session, skin.textureUrl(), skin, cape, geometry)); | ||
| packet.setSkin(getSkin(session, skin.textureUrl(), skin, cape, geometry, false, true)); |
Collaborator
There was a problem hiding this comment.
Nitpick, maybeee use isPersona, isCapeOnClassic instead of false, true here...
Contributor
Author
There was a problem hiding this comment.
I dont really see a reason for this considering java players are considered classic skins anyway
onebeastchris
requested changes
Nov 15, 2025
Member
onebeastchris
left a comment
onebeastchris
left a comment
There was a problem hiding this comment.
Looks like "persona" is always false here, so i'm unsure what that's good for... esp if Geyser doesn't support those skins anyways :p
Does just setting the capeOnClassic property work? Would rather just change that tbh
Comment on lines
+131
to
+132
| boolean isPersona = false; | ||
| boolean isCapeOnClassic = true; |
Member
There was a problem hiding this comment.
Why are these local variables? Doesn't seem like they're used for anything else
| .geometryData(geometry.geometryData().isBlank() ? GEOMETRY : geometry.geometryData()) | ||
| .premium(true) | ||
| .capeId(cape.capeId()) | ||
| .fullSkinId(skinId) |
Contributor
Author
|
i think it does, will clean up this pr when i get the time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4374.
However, due to a bug in the Bedrock Edition client, the elytras will swap with another player (see video below).
ScreenRecording_11-04-2025_19-58-25_1.mov