Fix video player not playing when GalleryVC is opened #3773
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughA bug fix was implemented in the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant GalleryVC
participant AttachmentsCollectionView
User->>GalleryVC: View appears
GalleryVC->>GalleryVC: updateContent()
GalleryVC->>AttachmentsCollectionView: scrollToItem(at: currentPage)
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Generated by 🚫 Danger |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)Sources/StreamChatUI/Gallery/GalleryVC.swift(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
Sources/StreamChatUI/Gallery/GalleryVC.swift (1)
Sources/StreamChatUI/CommonViews/BaseViews.swift (1)
updateContent(138-138)
🔇 Additional comments (1)
CHANGELOG.md (1)
17-17: Changelog entry looks good – consistent with existing format.
No issues spotted.
martinmitrevski
approved these changes
Aug 6, 2025
SDK Size
|
SDK Performance
|
Public Interface🚀 No changes affecting the public interface. |
SDK Size
|
nuno-vieira
added a commit
that referenced
this pull request
Aug 6, 2025
* Fix video player not playing when GalleryVC is opened * Update CHANGELOG.md * Fix swift format
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Caught in regression testing: #3770
🎯 Goal
Fix video player not playing when GalleryVC is opened.
🛠 Implementation
Caused by #3745. When doing the fix, the
updateContent()function was forgotten to be called on viewDidAppear(). This is where we start the video player if needed.🧪 Manual Testing Notes
☑️ Contributor Checklist
docs-contentrepoSummary by CodeRabbit