-
Notifications
You must be signed in to change notification settings - Fork 293
feat: support overriding components in MessageList #2890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +183 B (+0.02%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
arnautov-anton
approved these changes
Dec 2, 2025
Contributor
arnautov-anton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 🌮
myandrienko
added a commit
that referenced
this pull request
Dec 2, 2025
🚂 #2890 Two minor follow-up fixes: - Typings for MessageListWrapper and MessageListItem overridable components. - Don't use private ComponentProvider API in tests, use WithComponents instead.
|
🎉 This PR is included in version 13.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
This PR aligns overriding functionality between the VirtualizedMessageList (VML) and the regular MessageList (ML).
The goal is to be able to integrate components like React Aria's GridList into ML.
Currently, VML supports overriding the list and item components via
additionalVirtuosoProps.components. This PR adds the same ability to ML via the ComponentContext.🛠 Implementation details
We add two more components to ComponentContext:
ul).li).These components are consumed in MessageList and in
renderMessages()respectively.This makes the following usage possible:
Sometimes it's also valuable to be able to access the current
RenderedMessageitem from MessageListItem component. In VML it's possible by accessing Virtuoso's context to getprocessedMessagesand using thedata-indexattribute to get item's index.To align this functionality with ML, this PR adds
processedMessagesto MessageListContext, and addsdata-indexattribute to message list items.🎨 UI Changes
None by default.