feat: add support for global modal rendering at the top of the chat component tree #2792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +6 kB (+0.54%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2792 +/- ##
==========================================
+ Coverage 81.21% 81.28% +0.07%
==========================================
Files 487 488 +1
Lines 9785 9893 +108
Branches 2215 2243 +28
==========================================
+ Hits 7947 8042 +95
- Misses 1728 1740 +12
- Partials 110 111 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oliverlaz
approved these changes
Aug 8, 2025
Comment on lines
+69
to
+72
| <button | ||
| className='str-chat__modal__close-button' | ||
| ref={closeRef} | ||
| title={t('Close')} |
There was a problem hiding this comment.
Maybe also add type="button" so this doesn't accidentally submit parent forms?
src/components/Modal/GlobalModal.tsx
Outdated
| if (open && !dialog.isOpen) { | ||
| dialog.open(); | ||
| } | ||
| }, [dialog, open, children]); |
There was a problem hiding this comment.
Are children required in the dependency array? This would make this effect run on every re-render.
There was a problem hiding this comment.
No idea why I put it there
| [id], | ||
| ); | ||
|
|
||
| addDialogManager(dialogManager); |
There was a problem hiding this comment.
Should this go inside the useEffect instead?
There was a problem hiding this comment.
running it inside the effect makes this code to execute later than the children that try to access the manager during the render. addDialogManager does nothing if the manager exists so it does not cause any harm, but makes sure that children rendering below have the manager available.
There was a problem hiding this comment.
But, why don't children access it via the context provider?
There was a problem hiding this comment.
There is access through the provider - which is the fallback if manager id or dialog id are not specified. If you have a component rendered under two dialog manager providers and the component wants the top level manager, then here we circumvent the context.
There was a problem hiding this comment.
It still feels like an anti-pattern. Can we structure this differently so we keep the DialogManagerProvider render pure?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Allow to render the modal at the top of chat app.
Fixes REACT-22
Fixes REACT-340
Fixes the issue of modal overlay being cut-off in Safari because the parent was the message thus limiting the overlay position fixed to the message list.
Depends on CSS adjustments: GetStream/stream-chat-css#341
This is an opt-in feature. The top-level modal rendering is activated by passing
GlobalModaltoChanneland thus theComponentContext:🛠 Implementation details
The PR introduces possibility of nested
DialogManagerProviders(Modal > MessageList) and thus allowing to retrieve a dialog manager other than the one from the nearest dialog manager context.🎨 UI Changes
None
Docs
https://github.com/GetStream/docs-content/pull/519