fix: add missing app config fields to AppSettingsAPIResponse - #1854
Merged
Conversation
The scheduled test-types job caught server-side app config fields that types.ts was missing, causing the live GetApp response to fail type checking (moderation_keyframe_video_enabled and others).
oliverlaz
requested review from
MartinCupela,
isekovanic,
santhoshvai,
szuperaz and
vishalnarkhede
as code owners
September 7, 2026 09:25
MartinCupela
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The scheduled type-check job (https://github.com/GetStream/stream-chat-js/actions/runs/34104186289) failed because the live GetApp response now includes fields that
AppSettingsAPIResponse.appdoesn't declare, most visiblymoderation_keyframe_video_enabled.Cross-checked the full
AppResponseFieldsschema in the server-side OpenAPI spec againstsrc/types.tsand found 8 fields missing in total, so all of them are added here to avoid repeat failures on the next scheduled run:activity_metrics_config,chat_primary_use_case,member_custom_on_mentioned_users_enabled,member_custom_on_messages_enabled,member_custom_on_typing_events_enabled,moderation_keyframe_video_enabled,moderation_s3_image_access_role_arn,video_primary_use_case.Test plan
yarn typespassesyarn lintpassesyarn test— 3138 passed, 1 skippedyarn test-typeswill re-run against the live API on the next scheduled job (needs live credentials, not run locally)