Skip to content

fix(ci): drop internal group from TestFlight upload_to_testflight - #2839

Merged
testableapple merged 2 commits into
masterfrom
ci/resolve-tf-issue
Jul 22, 2026
Merged

fix(ci): drop internal group from TestFlight upload_to_testflight#2839
testableapple merged 2 commits into
masterfrom
ci/resolve-tf-issue

Conversation

@testableapple

@testableapple testableapple commented Jul 22, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Updated TestFlight distribution so external uploads explicitly target the External Testers group.
    • Adjusted internal TestFlight distribution to proceed without assigning a specific tester group.
    • Kept existing settings for upload behavior, notifications, changelog, and build processing as before.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 60ef23a7-4cf0-4222-b7ef-c02691737239

📥 Commits

Reviewing files that changed from the base of the PR and between 4ad3b41 and 4a10566.

📒 Files selected for processing (1)
  • sample_app/ios/fastlane/Fastfile

📝 Walkthrough

Walkthrough

The iOS TestFlight lanes update tester-group handling: external distributions explicitly target External Testers, while internal distributions no longer pass a group.

Changes

TestFlight distribution

Layer / File(s) Summary
Update TestFlight upload groups
sample_app/ios/fastlane/Fastfile
The external lane explicitly passes ['External Testers']; the internal lane removes ['Internal Testers'] while retaining its other upload parameters.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: xsahil03x

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main TestFlight change and is specific enough, though it only mentions the internal group removal.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/resolve-tf-issue

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@testableapple
testableapple merged commit 6251ca5 into master Jul 22, 2026
33 of 37 checks passed
@testableapple
testableapple deleted the ci/resolve-tf-issue branch July 22, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants