feat: add opt-in retry for rate-limited and transport-failed requests - #129
Merged
Conversation
Every other final-failure path in MakeRequest's retry loop logged an ERROR http.request.failed; the ctx.Done() branch returned silently. Also add missing behavior-matrix coverage: HEAD is retry-eligible, a 5xx is never retried even with retries enabled, and cancelling during backoff exits promptly with exactly one attempt and one ERROR log.
mogita
temporarily deployed
to
feeds-enabled-shard
July 23, 2026 14:35 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 23, 2026 14:35 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 23, 2026 14:35 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 23, 2026 14:35 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 23, 2026 14:35 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
mogita
had a problem deploying
to
feeds-enabled-shard
July 23, 2026 14:35 — with
GitHub Actions
Failure
GitHub Actions
Failure
The HardDeleteChannels integration subtest has been intermittently failing for weeks: it hard-deletes two channels and requires the async delete task to reach status=completed within a 5-minute WaitForTask poll. When the shared test backend's async queue is backed up, the task does not finish in the window and WaitForTask returns a timeout (ErrTransport), which hard-failed the whole suite. That timeout is backend queue latency, not an SDK defect (the API call succeeds and returns a task, and WaitForTask polls it correctly). New requireTaskCompletedOrSkipOnTimeout helper t.Skips on a poll timeout while still failing on a genuine task failure (ErrTaskFailed) or API error, so real regressions are still caught and backend latency no longer flakes CI.
mogita
had a problem deploying
to
feeds-enabled-shard
July 24, 2026 09:12 — with
GitHub Actions
Failure
GitHub Actions
Failure
mogita
temporarily deployed
to
feeds-enabled-shard
July 24, 2026 09:12 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 24, 2026 09:12 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 24, 2026 09:12 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 24, 2026 09:12 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 24, 2026 09:12 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Three parallel integration tests mutate the app-global FileUploadConfig; because size_limit has no omitempty, a partial UpdateApp rewrites it to 0, which clobbered TestChatAppFileUploadConfigIntegration's read-back mid-verify and made it intermittently fail. A shared appConfigMu now serializes the set->verify->restore span in all three so they cannot overlap.
mogita
had a problem deploying
to
feeds-enabled-shard
July 24, 2026 12:49 — with
GitHub Actions
Failure
GitHub Actions
Failure
mogita
temporarily deployed
to
feeds-enabled-shard
July 24, 2026 12:49 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 24, 2026 12:49 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 24, 2026 12:49 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 24, 2026 12:49 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 24, 2026 12:49 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
…nfreezeChannel The frozen flag in an UpdateChannelPartial response can be hydrated from a read replica that lags the write, so FreezeUnfreezeChannel intermittently observed the pre-unfreeze value and failed. Assert on a re-read that retries until the state converges instead of trusting the write response, symmetric for both freeze and unfreeze.
mogita
temporarily deployed
to
feeds-enabled-shard
July 24, 2026 13:14 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 24, 2026 13:14 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 24, 2026 13:14 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 24, 2026 13:14 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 24, 2026 13:14 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 24, 2026 13:14 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://linear.app/stream/issue/CHA-2959/rate-limits-and-retry
Summary
Adds an opt-in auto-retry policy.
RetryConfigis disabled by default (maxAttempts=3,maxBackoff=30s). When enabled, retries ONLYGET/HEADrequests that fail with HTTP 429 or a transport error, honoringRetry-After(clamped tomaxBackoff) otherwise exponential backoff with full jitter. Never retries writes or 5xx; always honors the backendunrecoverableflag; surfaces the last attempt's error. Config surface:stream.WithRetry(RetryConfig{...})Notes
http.request.failedlog event with aretry.attemptfield (transport retries carryerror.type; 429 retries omit it, since that field is the transport-only enum).release-*branch flow). Publish via the release flow when ready.