chore(components-native): Remove Modalize Library #2877
Conversation
| "lodash": "^4.17.21", | ||
| "react-hook-form": "^7.52.0", | ||
| "react-intl": "^7.1.11", | ||
| "react-intl": "^6 || ^7", |
There was a problem hiding this comment.
that wasn't intended. let me see what happened here...
There was a problem hiding this comment.
ah, our peerDeps have this same value
I guess when I ran the uninstall command, it evaluated our dependency tree to see what state we are in, and normalized it to this value. notably the installed version has not changed at all, so I think this is fine.
There was a problem hiding this comment.
Yeah... i've seen this happen lately. I didn't realize that version ranges actually are valid for non-peerDeps.. so that surprised me but I guess it's fine!
Actually, wondering if we should remove the ^6 now? I vaguely recall it was related to the react 19 migration... but don't remember why I kept the ^6 around.
There was a problem hiding this comment.
If you leave it as is, we do need to bump the package-lock.json. Do an npm i and this will autogenerate for you:
There was a problem hiding this comment.
it might be because we still have some projects running 6.x.x versions?
I'll run npm i for those extra changes
…0608/remove-modalize
Deploying atlantis with
|
| Latest commit: |
8687e7b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://962cab8f.atlantis.pages.dev |
| Branch Preview URL: | https://job-140608-remove-modalize.atlantis.pages.dev |
jdeichert
merged commit 706c52f
into
JOB-140606-implement-it-in-content-overlay
Motivations
we are now using a different library to power our ContentOverlay making it no longer necessary to have the modalize package installed at all since that was the sole usage
Changes
Added
Changed
Deprecated
Removed
removed the modalize package from components native, and our package lock.
Fixed
Security
Testing
Changes can be
tested via Pre-release
In Atlantis we use Github's built in pull request reviews.