Skip to content

deoplying FE-BE as a single command using mup hooks #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

deoplying FE-BE as a single command using mup hooks #2

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bbd305
deoplying FE-BE as a single command using mup hooks. Updating deploym…
Mar 13, 2021
27ec74f
removing bash resolving command
Mar 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,13 @@ ssh-add

You can deploy the projects independently or both together with the following commands.

Deploy frontend and backend concurrently.
When deploying for the first time, use the following

```sh
bash install-deploy.sh
```

Post that deployment of frontend and backend can be done concurrently.

```sh
bash deploy-all.sh
Expand Down
4 changes: 3 additions & 1 deletion clone-sources.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
git clone https://github.com/GeriLife/wellbeing.git
cd wellbeing/app && meteor npm i && cd ../../

git clone https://github.com/GeriLife/wellbeing-client.git
git clone https://github.com/GeriLife/wellbeing-client.git
cd wellbeing-client/frontend && yarn && cd ../../
6 changes: 5 additions & 1 deletion deploy-all.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
./node_modules/.bin/concurrently "./deploy-backend.sh" "./deploy-frontend.sh"
cd wellbeing/app && meteor npm i && cd ../../
cd wellbeing-client/frontend && yarn && cd ../../

echo "export PATH=$PATH:$(npm get prefix)/bin" >> ~/.bashrc
Copy link
Member

@brylie brylie Mar 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to modify .bashrc for this deployment? That seems like an unnecessary side-effect. Can't we use a session variable in the shell script?

Copy link
Member Author

@shailee-m shailee-m Mar 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is not able to find local dependencies

sh ./deploy-backend.sh
2 changes: 2 additions & 0 deletions install-deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
sh clone-sources.sh
sh ./deploy-backend.sh
7 changes: 4 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
"author": "Brylie Christopher Oxley <[email protected]> <[email protected]>",
"license": "MIT",
"private": false,
"dependencies": {
"concurrently": "^6.0.0"
}
"scripts": {
"deploy-frontend": "cd wellbeing-client/frontend && yarn serve"
},
"dependencies": {}
}