feat!: add read-only mode, fix XDG behavior in get_data_dir() #79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_data_dir(), either with a function argreadonly=Trueor env varWAGS_TAILS_READONLY=true. If True, don't try tomkdir(), but otherwise run some broad checks to confirm that it's actually writeable (raise an error if they fail). This begins to address Wags-tails incorrectly reads config files on containers #78XDG_DATA_DIRSshould be read-only -- if one of the items already includes a directory namedwags_tails, use it, but skip otherwise)"read only mode" here is not truly read-only, because we will also need to force all source
.get_latest()calls to usefrom_local=True. Unfortunately, we don't have a terribly elegant way of changing things on that side, so I'd prefer to see if this is good enough for now: ifWAGS_TAILS_READONLY=trueis declared in an environment where the required data is already available at an expected location, then I would expect no further writes to happen. I think I may tackle a bigger redesign effort during an upcoming bikeshedding week.