-
Notifications
You must be signed in to change notification settings - Fork 0
feat!: Use longest compatible remaining transcript #439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This change does not address the inconsistency in the return values of I re-ran the test I used to identify #435 and it now produces consistent results: I still have concerns about the behavior of |
|
@jarbesfeld this isn't super pressing, but it'd be nice to have a unit-test that fails before this change and passes after. Maybe you could write a test that calls |
|
@zealws I added in the |
|
Awesome! As suspected, that test fails randomly when run without the associated change to 1 pass, 9 failures. And the returned transcript isn't usually the same in the failed tests. |
|
For comparison, against the |
closes #438