Rename test_pygmtlogo function to test_pygmtlogo_circle_no_wordmark and improve it#4617
Open
Rename test_pygmtlogo function to test_pygmtlogo_circle_no_wordmark and improve it#4617
Conversation
seisman
commented
May 2, 2026
| @pytest.mark.benchmark | ||
| @pytest.mark.mpl_image_compare | ||
| def test_pygmtlogo(): | ||
| def test_pygmtlogo_circle_no_wordmark(): |
Member
Author
There was a problem hiding this comment.
Other tests will be named like
test_pygmtlogo_circle_horizontal_wordmarktest_pygmtlogo_circle_vertical_wordmarktest_pygmtlogo_hexagon_no_wordmarktest_pygmtlogo_hexagon_horizontal_wordmarktest_pygmtlogo_hexagon_vertical_wordmark
| ) | ||
| fig.pygmtlogo( | ||
| position=Position((4, 1), anchor="CM", cstype="mapcoords"), theme="dark" | ||
| ) |
Member
Author
There was a problem hiding this comment.
Plan to add the two black-and-white logos below the colored versions in later PRs.
Contributor
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)Report last updated at commit de990cc |
Member
Author
13 tasks
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





As shown in the table in PR #4616, we will likely have 24 PyGMT logo variants. Maintaining 24 separate baseline images is impractical, so we plan to group multiple variants into a single test. A reasonable approach is to define six tests based on logo shape and wordmark configuration. Each test would include four variants: colored and black-and-white logos in both light and dark themes.
This PR renames the existing test from test_pygmtlogo (which is too general) to test_pygmtlogo_circle_no_wordmark. It also adds a basemap to make the default logo size easier to inspect.
It appears that the default width/height of the logos is slightly smaller than 2 cm, although I am not sure why this value is used.