Skip to content

Endpoint for requests by guest#255

Merged
Dao-Ho merged 4 commits intomainfrom
feat/requests-by-guest-endpoint
Apr 4, 2026
Merged

Endpoint for requests by guest#255
Dao-Ho merged 4 commits intomainfrom
feat/requests-by-guest-endpoint

Conversation

@manueltorres0
Copy link
Copy Markdown
Contributor

Description

  • set up and endpoint for getting the requests made by a specific guest
  • made a response model
  • registered the route in the server code
  • set up the repo method for the requests repo
  • tested http handler for the new endpoint

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (code improvement without changing functionality)
  • Documentation update
  • Configuration/infrastructure change
  • Performance improvement
  • Test coverage improvement

What Changed?

  • new endpoint

Testing & Validation

How this was tested

  1. http layer tests

Unfinished Work & Known Issues

  • None, this PR is complete and production-ready
  • The following items are intentionally deferred:
    • *** it would be recommendable to convert the room id column on requests to UUID instead of text to be able to use the index

Pre-Merge Checklist

Code Quality

  • Code follows the project's style guidelines and conventions
  • Self-review completed (I've reviewed my own code for obvious issues)
  • No debugging code, console logs, or commented-out code left behind
  • No merge conflicts with the base branch
  • Meaningful commit messages that explain the "why"

Testing & CI

  • All CI checks are passing
  • All new and existing tests pass locally
  • Test coverage hasn't decreased (or decrease is justified)
  • Linting passes without errors

Documentation

  • Code is self-documenting or includes helpful comments for complex logic
  • API documentation updated (if backend endpoints changed)
  • Type definitions are accurate and up-to-date

Reviewer Notes

  • Areas needing extra attention: ...
  • Questions for reviewers: ...

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 24.28571% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.45%. Comparing base (6033a10) to head (c8f6bf5).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
backend/internal/repository/requests.go 0.00% 33 Missing ⚠️
backend/internal/handler/requests.go 58.62% 10 Missing and 2 partials ⚠️
backend/internal/httpx/bind.go 0.00% 7 Missing ⚠️
backend/internal/service/server.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #255      +/-   ##
==========================================
- Coverage   20.37%   18.45%   -1.92%     
==========================================
  Files          39       41       +2     
  Lines        1453     1696     +243     
==========================================
+ Hits          296      313      +17     
- Misses       1153     1377     +224     
- Partials        4        6       +2     
Flag Coverage Δ
backend 18.45% <24.28%> (-1.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
backend/internal/models/requests.go 0.00% <ø> (ø)
backend/internal/service/server.go 0.00% <0.00%> (ø)
backend/internal/httpx/bind.go 0.00% <0.00%> (ø)
backend/internal/handler/requests.go 83.08% <58.62%> (-6.64%) ⬇️
backend/internal/repository/requests.go 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Dao-Ho
Dao-Ho previously requested changes Apr 4, 2026
Copy link
Copy Markdown
Contributor

@Dao-Ho Dao-Ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two cmts

}

return nil
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

util for validating when the struct/output already exists

@Dao-Ho Dao-Ho merged commit 6fcf414 into main Apr 4, 2026
6 checks passed
@Dao-Ho Dao-Ho deleted the feat/requests-by-guest-endpoint branch April 4, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants