Skip to content

update to guest fetching endpoint + models#253

Open
manueltorres0 wants to merge 2 commits intomainfrom
guest-model-endpoint-update
Open

update to guest fetching endpoint + models#253
manueltorres0 wants to merge 2 commits intomainfrom
guest-model-endpoint-update

Conversation

@manueltorres0
Copy link
Copy Markdown
Contributor

Description

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Refactoring (code improvement without changing functionality)
  • Documentation update
  • Configuration/infrastructure change
  • Performance improvement
  • Test coverage improvement

What Changed?

  • I added backend http handler and repo handler support for the new guest profile info needed for the midfis
  • added fields to the GuesWithStays model
  • adapted the FindGUestWithStayHistory repo method

Testing & Validation

How this was tested

  1. Missing http tests

Unfinished Work & Known Issues

  • The following items are intentionally deferred:
    • *** tests


Pre-Merge Checklist

Code Quality

  • Code follows the project's style guidelines and conventions
  • Self-review completed (I've reviewed my own code for obvious issues)
  • No debugging code, console logs, or commented-out code left behind
  • No merge conflicts with the base branch
  • Meaningful commit messages that explain the "why"

Testing & CI

  • All CI checks are passing
  • All new and existing tests pass locally
  • Test coverage hasn't decreased (or decrease is justified)
  • Linting passes without errors

Documentation

  • Code is self-documenting or includes helpful comments for complex logic
  • API documentation updated (if backend endpoints changed)
  • Type definitions are accurate and up-to-date

Reviewer Notes

  • Areas needing extra attention: ...
  • Questions for reviewers: ...

@manueltorres0 manueltorres0 marked this pull request as draft April 2, 2026 18:41
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 0% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.10%. Comparing base (6033a10) to head (aa56e85).

Files with missing lines Patch % Lines
backend/internal/repository/guests.go 0.00% 54 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
- Coverage   20.37%   20.10%   -0.27%     
==========================================
  Files          39       39              
  Lines        1453     1472      +19     
==========================================
  Hits          296      296              
- Misses       1153     1172      +19     
  Partials        4        4              
Flag Coverage Δ
backend 20.10% <0.00%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
backend/internal/repository/guests.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@manueltorres0 manueltorres0 marked this pull request as ready for review April 2, 2026 19:38
@manueltorres0 manueltorres0 changed the title update to the endpoint + models update to guest fetching endpoint + models Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant