Skip to content

feat/guests-mobile-midfi#251

Merged
Dao-Ho merged 6 commits intomainfrom
feat/guest-filters-midfi
Apr 4, 2026
Merged

feat/guests-mobile-midfi#251
Dao-Ho merged 6 commits intomainfrom
feat/guest-filters-midfi

Conversation

@manueltorres0
Copy link
Copy Markdown
Contributor

Description

  • changed the guests and guest profile page on mobile to fit the midfi
  • added support to remaining filters and search
  • added frontend components for data that is missing on backend but will be updated soon

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (code improvement without changing functionality)
  • Documentation update
  • Configuration/infrastructure change
  • Performance improvement
  • Test coverage improvement

Related Issue(s)

What Changed?

  • enhanced guest profile to include more guest details, activity information, and request info (in progress)
  • added backend group size endpoint for accurate group size filtering
  • added the remaining filters to the guests page, search + group size
  • styled the guests page according to midfis

Testing & Validation

How this was tested

  1. visually

Screenshots/Recordings

demo

Unfinished Work & Known Issues

  • The following items are intentionally deferred:
    • *** actually pulling all of the midfi data from BE (backend support is in progress)
    • *** finishing off some incomplete styling

Pre-Merge Checklist

Code Quality

  • Code follows the project's style guidelines and conventions
  • Self-review completed (I've reviewed my own code for obvious issues)
  • No debugging code, console logs, or commented-out code left behind
  • No merge conflicts with the base branch
  • Meaningful commit messages that explain the "why"

Testing & CI

  • All CI checks are passing
  • All new and existing tests pass locally
  • Test coverage hasn't decreased (or decrease is justified)
  • Linting passes without errors

Documentation

  • Code is self-documenting or includes helpful comments for complex logic
  • API documentation updated (if backend endpoints changed)
  • Type definitions are accurate and up-to-date

Reviewer Notes

  • Areas needing extra attention: ...
  • Questions for reviewers: ...

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 8.97%. Comparing base (e89757c) to head (27daeb4).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
backend/internal/repository/guest-bookings.go 0.00% 18 Missing ⚠️
backend/internal/handler/bookings.go 0.00% 6 Missing ⚠️
backend/internal/service/server.go 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #251       +/-   ##
==========================================
- Coverage   84.00%   8.97%   -75.03%     
==========================================
  Files           7     116      +109     
  Lines          50    4156     +4106     
  Branches       24      24               
==========================================
+ Hits           42     373      +331     
- Misses          8    3777     +3769     
- Partials        0       6        +6     
Flag Coverage Δ
backend 18.12% <0.00%> (?)
mobile 84.00% <ø> (ø)
web 0.75% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
backend/internal/handler/guests.go 97.43% <ø> (ø)
backend/internal/models/guests.go 0.00% <ø> (ø)
backend/internal/service/server.go 0.00% <0.00%> (ø)
backend/internal/handler/bookings.go 0.00% <0.00%> (ø)
backend/internal/repository/guest-bookings.go 0.00% <0.00%> (ø)

... and 104 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@Dao-Ho Dao-Ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Copy link
Copy Markdown
Contributor

@Dao-Ho Dao-Ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@Dao-Ho Dao-Ho merged commit ac4dee7 into main Apr 4, 2026
16 checks passed
@Dao-Ho Dao-Ho deleted the feat/guest-filters-midfi branch April 4, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants