Skip to content

feat: link frontend to backend for guests#220

Open
zaydaanjahangir wants to merge 12 commits intomainfrom
feat/129-link-geusts-frontend-to-backend
Open

feat: link frontend to backend for guests#220
zaydaanjahangir wants to merge 12 commits intomainfrom
feat/129-link-geusts-frontend-to-backend

Conversation

@zaydaanjahangir
Copy link
Copy Markdown
Contributor

@zaydaanjahangir zaydaanjahangir commented Mar 27, 2026

Description

Linking backend guests to frontend web

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (code improvement without changing functionality)
  • Documentation update
  • Configuration/infrastructure change
  • Performance improvement
  • Test coverage improvement

Related Issue(s)

Closes #
Related to #

What Changed?

  • Cleaned up the API contract (backend models + swagger) to align with most recent backend changes

Testing & Validation

How this was tested

  1. Tested locally
  2. Added a couple unit tests for specific behaviors

Screenshots/Recordings

Notes & Nuances

  • Filter for group size on backend only is for 5-20 rather than 5+ on designs, updated the FE to show 5-20 but will need to fix later

Pre-Merge Checklist

Code Quality

  • Code follows the project's style guidelines and conventions
  • Self-review completed (I've reviewed my own code for obvious issues)
  • No debugging code, console logs, or commented-out code left behind
  • No merge conflicts with the base branch
  • Meaningful commit messages that explain the "why"

Testing & CI

  • All CI checks are passing
  • All new and existing tests pass locally
  • Test coverage hasn't decreased (or decrease is justified)
  • Linting passes without errors

Documentation

  • Code is self-documenting or includes helpful comments for complex logic
  • API documentation updated (if backend endpoints changed)
  • Type definitions are accurate and up-to-date

Reviewer Notes

  • Areas needing extra attention: ...
  • Questions for reviewers: ...

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 47.70642% with 57 lines in your changes missing coverage. Please review.
✅ Project coverage is 11.67%. Comparing base (8c271dd) to head (3303821).

Files with missing lines Patch % Lines
...nts/web/src/components/guests/GuestProfileCard.tsx 0.00% 18 Missing ⚠️
backend/internal/repository/guests.go 43.75% 9 Missing ⚠️
clients/web/src/hooks/use-debounce.ts 0.00% 9 Missing ⚠️
...ts/web/src/components/guests/PreviousStaysCard.tsx 0.00% 8 Missing ⚠️
.../web/src/components/guests/GuestQuickListTable.tsx 42.85% 4 Missing ⚠️
...ients/web/src/components/guests/GuestNotesCard.tsx 0.00% 3 Missing ⚠️
clients/web/src/utils/dates.ts 62.50% 3 Missing ⚠️
...eb/src/components/guests/GuestSpecialNeedsCard.tsx 33.33% 2 Missing ⚠️
.../components/guests/HousekeepingPreferencesCard.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##            main     #220      +/-   ##
=========================================
+ Coverage   9.55%   11.67%   +2.11%     
=========================================
  Files        129      131       +2     
  Lines       5327     5304      -23     
  Branches      24       27       +3     
=========================================
+ Hits         509      619     +110     
+ Misses      4803     4670     -133     
  Partials      15       15              
Flag Coverage Δ
backend 20.35% <43.75%> (+0.17%) ⬆️
mobile 84.00% <ø> (ø)
web 4.06% <48.38%> (+3.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
backend/internal/handler/guests.go 97.43% <ø> (ø)
backend/internal/models/guests.go 0.00% <ø> (ø)
...src/components/guests/GuestProfilePageSkeleton.tsx 100.00% <100.00%> (ø)
...ents/web/src/routes/_protected/guests.$guestId.tsx 20.00% <100.00%> (+20.00%) ⬆️
clients/web/src/routes/_protected/guests.index.tsx 20.00% <100.00%> (+20.00%) ⬆️
.../components/guests/HousekeepingPreferencesCard.tsx 5.26% <50.00%> (ø)
...eb/src/components/guests/GuestSpecialNeedsCard.tsx 2.77% <33.33%> (ø)
...ients/web/src/components/guests/GuestNotesCard.tsx 0.00% <0.00%> (ø)
clients/web/src/utils/dates.ts 62.50% <62.50%> (ø)
.../web/src/components/guests/GuestQuickListTable.tsx 68.57% <42.85%> (+68.57%) ⬆️
... and 4 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zaydaanjahangir zaydaanjahangir marked this pull request as ready for review March 31, 2026 22:21
Copy link
Copy Markdown
Contributor

@Dao-Ho Dao-Ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments, this is a great ship overall!!

@zaydaanjahangir zaydaanjahangir requested a review from Dao-Ho April 4, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants