Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
pull_request, setMEETUP_SYNC_DEBUGby default in the job, and only run the commit step forpush,schedule, orworkflow_dispatchevents, and enhance the run-time stats output to show the most recent past event and URL.README.mdto documentMEETUP_PAST_EVENTS_URLandMEETUP_SYNC_DEBUGand to reflect the new workflow triggers and behavior.scripts/sync_meetup_events.pywith debug logging, unescaping of iCal text, better JSON-LD parsing (including@graphnodes), utilities to extract event URLs from meetup HTML, afetch_urlwrapper, merging of iCal and past-event lists, and a crawl of theevents/pastpage (and individual event pages) to supplement parsed past events.tests/test_sync_meetup_events.pycoveringextract_event_urls_from_htmland JSON-LD@graphparsing.Testing
python -m unittest tests.test_sync_meetup_eventsand the two included tests passed.scripts/sync_meetup_events.pywere exercised during development to verify parsing branches (no automated failures reported).Codex Task