Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5280d3a6f8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if merged_events: | ||
| return merged_events |
There was a problem hiding this comment.
Continue fallback to events page when iCal data is unavailable
Returning immediately on merged_events skips the /events/ fallback path whenever events/past has any data. In the scenario where the iCal source is down or empty but events/past succeeds, this function returns only past events and never fetches upcoming events from MEETUP_EVENTS_URL, so the site can silently lose all upcoming listings during an iCal outage. Only short-circuit here when iCal data is present, or merge in /events/ results before returning.
Useful? React with 👍 / 👎.
Motivation
Description
pull_requestand to only commit changes when the event was triggered bypush,schedule, orworkflow_dispatch, and update README to document trigger and a newMEETUP_PAST_EVENTS_URLoption.DEFAULT_PAST_EVENTS_URL,unescape_ical_text, and unescape ical fields inparse_ical_eventsto correctly handle escaped line breaks and characters from iCal.parse_ld_json_eventsto expand@graphnodes and parse richer JSON-LD shapes, and addmerge_eventsto deduplicate and combine multiple sources.extract_event_urls_from_htmlandfetch_urland updatefetch_eventsto first try iCal, then pull recent past events from theevents/pastpage (including individual event pages for details), merge results, and fall back to the main events page as needed.tests/test_sync_meetup_events.pycovering relative/absolute event link extraction and JSON-LD@graphnode parsing.Testing
python -m unittest tests/test_sync_meetup_events.pyand both tests passed.Codex Task