You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Allow the Meetup sync to run for pull requests and all pushes to main/master in addition to scheduled and manual runs to improve verification and CI feedback.
Supplement iCal and events page parsing with recent historical events from the Meetup events/past page to retain recent past events in the site data.
Improve robustness of iCal / JSON-LD parsing by unescaping ical text, deduplicating and merging multiple sources, and more reliable URL fetching.
Description
Updated workflow /.github/workflows/sync-meetup-events.yml to add pull_request triggers, document that pushes to main/master run, and restrict the commit step to only run on push, schedule, or workflow_dispatch events using if: github.event_name == 'push' || github.event_name == 'schedule' || github.event_name == 'workflow_dispatch'.
Extended README.md to document the new MEETUP_PAST_EVENTS_URL override and the updated workflow triggers and behavior.
Enhanced scripts/sync_meetup_events.py with these key changes: added DEFAULT_PAST_EVENTS_URL, implemented unescape_ical_text and applied it to SUMMARY, DESCRIPTION, and LOCATION when parsing iCal, added fetch_url, extract_event_urls_from_html, merge_events, and logic to fetch/supplement past events (including crawling individual event pages when needed), and changed fetch_events to merge iCal and past-event results with a JSON-LD fallback.
Improved error messages and logging when sources succeed or fail and ensured deterministic output via write_if_changed unchanged behavior.
Testing
No automated tests were run as part of this change.
Use events-page fallback when iCal data is missing
Returning immediately when merge_events(ical_events, past_events) is non-empty causes a regression during iCal outages: if the iCal request fails but events/past returns data, this path exits with only past events and never queries MEETUP_EVENTS_URL for upcoming events. In that scenario the site can temporarily show zero upcoming events even though the JSON-LD events page is still available.
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
main/masterin addition to scheduled and manual runs to improve verification and CI feedback.events/pastpage to retain recent past events in the site data.Description
/.github/workflows/sync-meetup-events.ymlto addpull_requesttriggers, document that pushes tomain/masterrun, and restrict the commit step to only run onpush,schedule, orworkflow_dispatchevents usingif: github.event_name == 'push' || github.event_name == 'schedule' || github.event_name == 'workflow_dispatch'.README.mdto document the newMEETUP_PAST_EVENTS_URLoverride and the updated workflow triggers and behavior.scripts/sync_meetup_events.pywith these key changes: addedDEFAULT_PAST_EVENTS_URL, implementedunescape_ical_textand applied it toSUMMARY,DESCRIPTION, andLOCATIONwhen parsing iCal, addedfetch_url,extract_event_urls_from_html,merge_events, and logic to fetch/supplement past events (including crawling individual event pages when needed), and changedfetch_eventsto merge iCal and past-event results with a JSON-LD fallback.write_if_changedunchanged behavior.Testing
Codex Task