Fix calling NewTess() with an empty datapath argument#14
Open
tsdko wants to merge 2 commits intoGeertJohan:masterfrom
Open
Fix calling NewTess() with an empty datapath argument#14tsdko wants to merge 2 commits intoGeertJohan:masterfrom
tsdko wants to merge 2 commits intoGeertJohan:masterfrom
Conversation
Passing NULL is the only way to make Tesseract use the compiled in TESSDATA_PREFIX constant.
tsdko
force-pushed
the
newtess-empty-datapath
branch
2 times, most recently
from
897d6b7 to
c796170
Compare
Contributor
Author
|
No feedback? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes passing an empty
datapathtoNewTess()actually passNULLtoTessBaseAPIInit3(). It's needed because passingNULLis the only way to make Tesseract use the compiled inTESSDATA_PREFIXconstant as the datapath (and Go won't allow passingnilwhen the argument type isstring).Code used to determine the datapath in Tesseract can be found in ccutil/mainblk.cpp.