fix: use enum values for userStatus instead of string on android#13
Open
osilviotti wants to merge 3 commits into
Open
fix: use enum values for userStatus instead of string on android#13osilviotti wants to merge 3 commits into
osilviotti wants to merge 3 commits into
Conversation
Owner
|
The android side works - @osilviotti - Can you try to upgrade the nitro package to 35.4+ so it will generate new nitro files for iOS. |
Author
|
Just added all the other generated files @Gautham495 |
Owner
|
@osilviotti - Thanks for the change, but there is an issue with the iOS types. This was not present before. |
Author
|
@Gautham495 I think that's because the types were changed in #10 without running I can make the changes to the Swift file if you're happy to test it |
Owner
|
The iOS side is not building which will cause issues, I will check this out - @osilviotti |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
yarn example androidI was getting the following error preventing the build from completing:I believe it came in with #10 when the type of
userStatuswas changed fromStringtoPlayAgeRangeDeclarationUserStatusValues.I've updated the user status check to explicitly return enum values, and the app now builds and runs on my Android device.
I don't have an iOS device to test on and it looks like a similar issue exists there with
statusStringbeing typed as aStringrather thanAppleAgeRangeDeclarationUserStatusValues(here) but didn't want to make any changes that I couldn't test.Note: I haven't worked with Nitro Modules before - I only committed the generated files that had diffs, happy to update the PR if I've done this wrong